Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
| Files | Infos | Warnings | Errors |
| 84 | 0 | 0 | 675 |
Files
pl/kernelpanic/dbmonster/DBMonster.java
| Error | Line |
| First sentence should end with a period. |
142
|
| First sentence should end with a period. |
147
|
| Method 'getConnectionProvider' is not designed for extension - needs to be abstract, final or empty. |
167
|
| Method 'setConnectionProvider' is not designed for extension - needs to be abstract, final or empty. |
176
|
| Parameter cp should be final. |
176
|
| Method 'addSchema' is not designed for extension - needs to be abstract, final or empty. |
187
|
| Parameter schema should be final. |
187
|
| Line is longer than 80 characters. |
190
|
| Method 'setLogger' is not designed for extension - needs to be abstract, final or empty. |
200
|
| Parameter log should be final. |
200
|
| Method 'getLogger' is not designed for extension - needs to be abstract, final or empty. |
209
|
| Method 'setProperties' is not designed for extension - needs to be abstract, final or empty. |
218
|
| Parameter props should be final. |
218
|
| Method 'doTheJob' is not designed for extension - needs to be abstract, final or empty. |
236
|
| Line is longer than 80 characters. |
257
|
| Line is longer than 80 characters. |
259
|
| Parameter schema should be final. |
322
|
| Method 'getProgressMonitor' is not designed for extension - needs to be abstract, final or empty. |
336
|
| Method 'setProgressMonitor' is not designed for extension - needs to be abstract, final or empty. |
345
|
| Parameter monitor should be final. |
345
|
| Method 'setPostScript' is not designed for extension - needs to be abstract, final or empty. |
349
|
| Missing a Javadoc comment. |
349
|
| Parameter postScript should be final. |
349
|
| 'postScript' hides a field. |
349
|
| Method 'setPreScript' is not designed for extension - needs to be abstract, final or empty. |
353
|
| Missing a Javadoc comment. |
353
|
| Parameter preScript should be final. |
353
|
| 'preScript' hides a field. |
353
|
| Method 'setTransactionSize' is not designed for extension - needs to be abstract, final or empty. |
357
|
| Missing a Javadoc comment. |
357
|
| Parameter transactionSize should be final. |
357
|
| 'transactionSize' hides a field. |
357
|
| Line is longer than 80 characters. |
361
|
| Missing a Javadoc comment. |
361
|
| Parameter cp should be final. |
361
|
| Parameter scriptFile should be final. |
361
|
pl/kernelpanic/dbmonster/DBMonsterContext.java
| Error | Line |
| Method 'getProperty' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Parameter key should be final. |
73
|
| Method 'setProperty' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Parameter key should be final. |
83
|
| Parameter value should be final. |
83
|
pl/kernelpanic/dbmonster/Dictionary.java
| Error | Line |
| Method 'getNextRandomItem' is not designed for extension - needs to be abstract, final or empty. |
87
|
| Method 'getNextUniqueItem' is not designed for extension - needs to be abstract, final or empty. |
98
|
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. |
106
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
115
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
124
|
| Parameter s should be final. |
124
|
| Method 'setRandom' is not designed for extension - needs to be abstract, final or empty. |
133
|
| Parameter r should be final. |
133
|
| Method 'addItem' is not designed for extension - needs to be abstract, final or empty. |
142
|
| Parameter item should be final. |
142
|
pl/kernelpanic/dbmonster/DictionaryManager.java
| Error | Line |
| Method 'setRandom' is not designed for extension - needs to be abstract, final or empty. |
86
|
| Parameter rnd should be final. |
86
|
| Line is longer than 80 characters. |
100
|
| Method 'getDictionary' is not designed for extension - needs to be abstract, final or empty. |
100
|
| Parameter schemaPath should be final. |
100
|
| Parameter path should be final. |
100
|
| Method 'getDictionary' is not designed for extension - needs to be abstract, final or empty. |
123
|
| Parameter url should be final. |
123
|
| Parameter path should be final. |
139
|
| Parameter url should be final. |
165
|
| Parameter key should be final. |
178
|
| Parameter is should be final. |
178
|
pl/kernelpanic/dbmonster/Launcher.java
| Error | Line |
| Parameter args should be final. |
100
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
115
|
| Parameter args should be final. |
115
|
| Line is longer than 80 characters. |
159
|
| Line is longer than 80 characters. |
165
|
| Line is longer than 80 characters. |
189
|
| Must have at least one statement. |
190
|
| '{' is not followed by whitespace. |
190
|
| '}' is not preceded with whitespace. |
190
|
| Line is longer than 80 characters. |
193
|
| Must have at least one statement. |
194
|
| '{' is not followed by whitespace. |
194
|
| '}' is not preceded with whitespace. |
194
|
| Line has trailing spaces. |
198
|
| First sentence should end with a period. |
210
|
| Parameter file should be final. |
231
|
| Parameter args should be final. |
261
|
| Line is longer than 80 characters. |
307
|
| Line is longer than 80 characters. |
314
|
| Line has trailing spaces. |
324
|
pl/kernelpanic/dbmonster/ProgressMonitorAdapter.java
| Error | Line |
| Line does not match expected header line of '/* Version 1.0 based on Apache Software License 1.1'. |
1
|
| Missing a Javadoc comment. |
25
|
| Variable 'schemasCount' must be private and have accessor methods. |
25
|
| Missing a Javadoc comment. |
26
|
| Variable 'tablesCount' must be private and have accessor methods. |
26
|
| Missing a Javadoc comment. |
27
|
| Variable 'rowsCount' must be private and have accessor methods. |
27
|
| Missing a Javadoc comment. |
28
|
| Variable 'schemaName' must be private and have accessor methods. |
28
|
| Missing a Javadoc comment. |
29
|
| Variable 'tableName' must be private and have accessor methods. |
29
|
| Line has trailing spaces. |
30
|
| Missing a Javadoc comment. |
31
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
37
|
| Missing a Javadoc comment. |
40
|
| Missing a Javadoc comment. |
43
|
| Method 'setSchemaCount' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Missing a Javadoc comment. |
46
|
| Parameter count should be final. |
46
|
| Method 'setTableCount' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Missing a Javadoc comment. |
50
|
| Parameter count should be final. |
50
|
| Method 'setRowsCount' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Missing a Javadoc comment. |
54
|
| Parameter count should be final. |
54
|
| Missing a Javadoc comment. |
58
|
| Missing a Javadoc comment. |
61
|
| Missing a Javadoc comment. |
64
|
| Method 'setSchemaName' is not designed for extension - needs to be abstract, final or empty. |
67
|
| Missing a Javadoc comment. |
67
|
| Parameter name should be final. |
67
|
| Method 'setTableName' is not designed for extension - needs to be abstract, final or empty. |
71
|
| Missing a Javadoc comment. |
71
|
| Parameter name should be final. |
71
|
pl/kernelpanic/dbmonster/SchemaGrabber.java
| Error | Line |
| '1000' is a magic number. |
134
|
| First sentence should end with a period. |
142
|
| Parameter args should be final. |
149
|
| Method 'doTheJob' is not designed for extension - needs to be abstract, final or empty. |
163
|
| Method 'getOutput' is not designed for extension - needs to be abstract, final or empty. |
174
|
| Method 'grabSchema' is not designed for extension - needs to be abstract, final or empty. |
185
|
| Must have at least one statement. |
195
|
| '100' is a magic number. |
212
|
| Method 'grabTable' is not designed for extension - needs to be abstract, final or empty. |
229
|
| Parameter name should be final. |
229
|
| '}' should be on the same line. |
258
|
| Method 'getTableNames' is not designed for extension - needs to be abstract, final or empty. |
312
|
| Method 'getConnectionProvider' is not designed for extension - needs to be abstract, final or empty. |
343
|
| Method 'setConnectionProvider' is not designed for extension - needs to be abstract, final or empty. |
352
|
| Parameter provider should be final. |
352
|
| Method 'getLog' is not designed for extension - needs to be abstract, final or empty. |
361
|
| First sentence should end with a period. |
365
|
| Method 'setLog' is not designed for extension - needs to be abstract, final or empty. |
370
|
| Parameter logger should be final. |
370
|
| Method 'addTable' is not designed for extension - needs to be abstract, final or empty. |
381
|
| Parameter name should be final. |
381
|
| Method 'setOutputFile' is not designed for extension - needs to be abstract, final or empty. |
421
|
| Parameter file should be final. |
421
|
| First sentence should end with a period. |
426
|
| Method 'setProperties' is not designed for extension - needs to be abstract, final or empty. |
430
|
| Parameter p should be final. |
430
|
| Expected @param tag for 'p'. |
430
|
| Line is longer than 80 characters. |
446
|
| Parameter tableName should be final. |
446
|
| Parameter columns should be final. |
446
|
| Parameter tableName should be final. |
500
|
| Parameter columnName should be final. |
501
|
| Parameter foreignKeys should be final. |
502
|
| '10' is a magic number. |
526
|
| Line is longer than 80 characters. |
541
|
| Line has trailing spaces. |
584
|
| Parameter type should be final. |
606
|
| Line has trailing spaces. |
608
|
| Line has trailing spaces. |
612
|
| Line has trailing spaces. |
623
|
| Line has trailing spaces. |
625
|
| Line has trailing spaces. |
626
|
| Parameter type should be final. |
629
|
| Line has trailing spaces. |
632
|
| Parameter type should be final. |
640
|
| Line has trailing spaces. |
642
|
| Line has trailing spaces. |
646
|
| Parameter type should be final. |
658
|
| Line has trailing spaces. |
660
|
| Line has trailing spaces. |
664
|
| First sentence should end with a period. |
670
|
| Parameter type should be final. |
677
|
| Line has trailing spaces. |
679
|
| Line has trailing spaces. |
683
|
| Line has trailing spaces. |
687
|
| First sentence should end with a period. |
688
|
| Line has trailing spaces. |
690
|
| Line has trailing spaces. |
692
|
| Line has trailing spaces. |
693
|
| Parameter type should be final. |
696
|
| Conditional logic can be removed. |
697
|
| Line has trailing spaces. |
700
|
| '{' should be on the previous line. |
701
|
| Line has trailing spaces. |
706
|
| First sentence should end with a period. |
724
|
| Parameter k should be final. |
730
|
| Parameter v should be final. |
730
|
| Parameter k should be final. |
749
|
| First sentence should end with a period. |
762
|
| Parameter v should be final. |
767
|
pl/kernelpanic/dbmonster/connection/ConnectionProvider.java
| Error | Line |
| Expected @param tag for 'autoCommit'. |
88
|
pl/kernelpanic/dbmonster/connection/DBCPConnectionProvider.java
| Error | Line |
| Line is longer than 80 characters. |
80
|
| Missing a Javadoc comment. |
124
|
| Parameter jdbcDriver should be final. |
147
|
| Parameter jdbcUrl should be final. |
148
|
| Parameter jdbcUsername should be final. |
149
|
| Parameter jdbcPassword should be final. |
150
|
| Parameter jdbcDriver should be final. |
170
|
| Parameter jdbcUrl should be final. |
171
|
| Parameter props should be final. |
172
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
183
|
| Method 'testConnection' is not designed for extension - needs to be abstract, final or empty. |
195
|
| Method 'setLogger' is not designed for extension - needs to be abstract, final or empty. |
213
|
| Parameter log should be final. |
213
|
| Method 'shutdown' is not designed for extension - needs to be abstract, final or empty. |
220
|
| Must have at least one statement. |
223
|
| Method 'setAutoCommit' is not designed for extension - needs to be abstract, final or empty. |
264
|
| Missing a Javadoc comment. |
264
|
| Parameter autoCommit should be final. |
264
|
| 'autoCommit' hides a field. |
264
|
pl/kernelpanic/dbmonster/connection/SimpleConnectionProvider.java
| Error | Line |
| Line is longer than 80 characters. |
73
|
| Missing a Javadoc comment. |
108
|
| Missing a Javadoc comment. |
110
|
| Parameter jdbcDriver should be final. |
132
|
| Parameter jdbcUrl should be final. |
133
|
| Parameter jdbcUsername should be final. |
134
|
| Parameter jdbcPassword should be final. |
135
|
| Parameter jdbcDriver should be final. |
154
|
| Parameter jdbcUrl should be final. |
155
|
| Parameter props should be final. |
156
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
166
|
| Method 'testConnection' is not designed for extension - needs to be abstract, final or empty. |
180
|
| Method 'setLogger' is not designed for extension - needs to be abstract, final or empty. |
198
|
| Parameter log should be final. |
198
|
| Method 'shutdown' is not designed for extension - needs to be abstract, final or empty. |
205
|
| Method 'setAutoCommit' is not designed for extension - needs to be abstract, final or empty. |
231
|
| Missing a Javadoc comment. |
231
|
| Parameter autoCommit should be final. |
231
|
| 'autoCommit' hides a field. |
231
|
pl/kernelpanic/dbmonster/connection/Transaction.java
| Error | Line |
| Parameter cp should be final. |
95
|
| Method 'begin' is not designed for extension - needs to be abstract, final or empty. |
106
|
| Method 'commit' is not designed for extension - needs to be abstract, final or empty. |
116
|
| Method 'abort' is not designed for extension - needs to be abstract, final or empty. |
133
|
| Must have at least one statement. |
136
|
| Line has trailing spaces. |
137
|
| Must have at least one statement. |
148
|
| Line has trailing spaces. |
149
|
| Must have at least one statement. |
158
|
| Line has trailing spaces. |
159
|
| Must have at least one statement. |
168
|
| Line has trailing spaces. |
169
|
| Must have at least one statement. |
178
|
| Line has trailing spaces. |
179
|
| Method 'executeQuery' is not designed for extension - needs to be abstract, final or empty. |
195
|
| Parameter query should be final. |
195
|
| Method 'prepareStatement' is not designed for extension - needs to be abstract, final or empty. |
212
|
| Parameter query should be final. |
212
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
223
|
pl/kernelpanic/dbmonster/generator/BasicDataGenerator.java
| Error | Line |
| Unclosed HTML tag found: <pm@jcake.com> |
55
|
| Variable 'nulls' must be private and have accessor methods. |
64
|
| Variable 'column' must be private and have accessor methods. |
69
|
| Method 'setColumn' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Parameter col should be final. |
76
|
| Method 'getColumn' is not designed for extension - needs to be abstract, final or empty. |
80
|
| Missing a Javadoc comment. |
80
|
| Method 'getNulls' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Method 'setNulls' is not designed for extension - needs to be abstract, final or empty. |
98
|
| Parameter count should be final. |
98
|
pl/kernelpanic/dbmonster/generator/BinaryGenerator.java
| Error | Line |
| Line does not match expected header line of '/* Version 1.0 based on Apache Software License 1.1'. |
1
|
| Line is longer than 80 characters. |
62
|
| Missing a Javadoc comment. |
62
|
| First sentence should end with a period. |
64
|
| Line has trailing spaces. |
66
|
| First sentence should end with a period. |
67
|
| Line has trailing spaces. |
69
|
| Line has trailing spaces. |
72
|
| First sentence should end with a period. |
73
|
| Line has trailing spaces. |
75
|
| First sentence should end with a period. |
76
|
| Line has trailing spaces. |
84
|
| Line has trailing spaces. |
85
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
85
|
| Parameter ctx should be final. |
85
|
| '{' should be on the previous line. |
87
|
| Line has trailing spaces. |
91
|
| Line has trailing spaces. |
96
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
97
|
| Expected @throws tag for 'Exception'. |
97
|
| '101' is a magic number. |
98
|
| 'cast' is not followed by whitespace. |
104
|
| '8192' is a magic number. |
108
|
| Line is longer than 80 characters. |
125
|
| '+' is not preceded with whitespace. |
125
|
| '+' is not followed by whitespace. |
125
|
| 'if' construct must use '{}'s. |
127
|
| Must have at least one statement. |
127
|
| '{' is not followed by whitespace. |
127
|
| '}' is not preceded with whitespace. |
127
|
| Line has trailing spaces. |
130
|
| Line has trailing spaces. |
140
|
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. |
141
|
| Missing a Javadoc comment. |
141
|
| Line has trailing spaces. |
146
|
| Line has trailing spaces. |
148
|
| Line has trailing spaces. |
150
|
| Method 'setFile' is not designed for extension - needs to be abstract, final or empty. |
152
|
| Parameter value should be final. |
152
|
| Line has trailing spaces. |
155
|
| Method 'getMaxLength' is not designed for extension - needs to be abstract, final or empty. |
161
|
| Method 'setMaxLength' is not designed for extension - needs to be abstract, final or empty. |
170
|
| Parameter length should be final. |
170
|
| Expected an @return tag. |
178
|
pl/kernelpanic/dbmonster/generator/BooleanGenerator.java
| Error | Line |
| Line is longer than 80 characters. |
62
|
| '50' is a magic number. |
67
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
82
|
| Parameter ctx should be final. |
82
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
92
|
| '101' is a magic number. |
94
|
| '101' is a magic number. |
98
|
| Method 'getProbability' is not designed for extension - needs to be abstract, final or empty. |
109
|
| Method 'setProbability' is not designed for extension - needs to be abstract, final or empty. |
118
|
| Parameter prob should be final. |
118
|
pl/kernelpanic/dbmonster/generator/ConstantGenerator.java
| Error | Line |
| Line has trailing spaces. |
63
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
69
|
| Method 'getConstant' is not designed for extension - needs to be abstract, final or empty. |
82
|
| Method 'setConstant' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Parameter constant should be final. |
89
|
| 'constant' hides a field. |
89
|
pl/kernelpanic/dbmonster/generator/DateTimeGenerator.java
| Error | Line |
| Line is longer than 80 characters. |
67
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
119
|
| Parameter ctx should be final. |
119
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
131
|
| '101' is a magic number. |
133
|
| Method 'getStartDate' is not designed for extension - needs to be abstract, final or empty. |
155
|
| Method 'setStartDate' is not designed for extension - needs to be abstract, final or empty. |
166
|
| Parameter start should be final. |
166
|
| Method 'getEndDate' is not designed for extension - needs to be abstract, final or empty. |
175
|
| Method 'setEndDate' is not designed for extension - needs to be abstract, final or empty. |
186
|
| Parameter end should be final. |
186
|
| Method 'getReturnedType' is not designed for extension - needs to be abstract, final or empty. |
195
|
| Method 'setReturnedType' is not designed for extension - needs to be abstract, final or empty. |
210
|
| Parameter type should be final. |
210
|
| Parameter dateStr should be final. |
235
|
| '10' is a magic number. |
240
|
| '16' is a magic number. |
243
|
| '19' is a magic number. |
246
|
| '23' is a magic number. |
249
|
pl/kernelpanic/dbmonster/generator/DictionaryGenerator.java
| Error | Line |
| Line is longer than 80 characters. |
86
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
120
|
| Parameter ctx should be final. |
120
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
136
|
| Method 'setDictFile' is not designed for extension - needs to be abstract, final or empty. |
153
|
| Parameter name should be final. |
153
|
| Method 'getDictFile' is not designed for extension - needs to be abstract, final or empty. |
162
|
| Method 'setUnique' is not designed for extension - needs to be abstract, final or empty. |
171
|
| Parameter b should be final. |
171
|
| Method 'getUnique' is not designed for extension - needs to be abstract, final or empty. |
181
|
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. |
188
|
pl/kernelpanic/dbmonster/generator/ForeignKeyGenerator.java
| Error | Line |
| Line is longer than 80 characters. |
74
|
| First sentence should end with a period. |
116
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
138
|
| Parameter ctx should be final. |
138
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
164
|
| Method 'getColumnName' is not designed for extension - needs to be abstract, final or empty. |
284
|
| Method 'setColumnName' is not designed for extension - needs to be abstract, final or empty. |
293
|
| Parameter name should be final. |
293
|
| Method 'getTableName' is not designed for extension - needs to be abstract, final or empty. |
302
|
| Method 'setTableName' is not designed for extension - needs to be abstract, final or empty. |
311
|
| Parameter name should be final. |
311
|
| Method 'getFastMode' is not designed for extension - needs to be abstract, final or empty. |
320
|
| Method 'setFastMode' is not designed for extension - needs to be abstract, final or empty. |
329
|
| Parameter mode should be final. |
329
|
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. |
336
|
pl/kernelpanic/dbmonster/generator/KeyGenerator.java
| Error | Line |
| First sentence should end with a period. |
69
|
| Expected an @return tag. |
72
|
pl/kernelpanic/dbmonster/generator/MaxKeyGenerator.java
| Error | Line |
| Method 'setKey' is not designed for extension - needs to be abstract, final or empty. |
96
|
| Parameter k should be final. |
96
|
| Method 'getKey' is not designed for extension - needs to be abstract, final or empty. |
100
|
| Missing a Javadoc comment. |
100
|
| Method 'getColumns' is not designed for extension - needs to be abstract, final or empty. |
109
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
118
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
127
|
| Parameter ctx should be final. |
127
|
| Method 'getColumnName' is not designed for extension - needs to be abstract, final or empty. |
179
|
| Method 'setColumnName' is not designed for extension - needs to be abstract, final or empty. |
194
|
| Parameter name should be final. |
194
|
pl/kernelpanic/dbmonster/generator/NullGenerator.java
| Error | Line |
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
64
|
pl/kernelpanic/dbmonster/generator/NumberGenerator.java
| Error | Line |
| Line is longer than 80 characters. |
62
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
128
|
| Parameter ctx should be final. |
128
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
140
|
| '101' is a magic number. |
142
|
| Method 'getMinValue' is not designed for extension - needs to be abstract, final or empty. |
174
|
| Method 'setMinValue' is not designed for extension - needs to be abstract, final or empty. |
183
|
| Parameter minVal should be final. |
183
|
| Method 'getMaxValue' is not designed for extension - needs to be abstract, final or empty. |
192
|
| Method 'setMaxValue' is not designed for extension - needs to be abstract, final or empty. |
201
|
| Parameter maxVal should be final. |
201
|
| Method 'getScale' is not designed for extension - needs to be abstract, final or empty. |
210
|
| Method 'setScale' is not designed for extension - needs to be abstract, final or empty. |
219
|
| Parameter s should be final. |
219
|
| Method 'getReturnedType' is not designed for extension - needs to be abstract, final or empty. |
228
|
| Method 'setReturnedType' is not designed for extension - needs to be abstract, final or empty. |
252
|
| Parameter type should be final. |
252
|
pl/kernelpanic/dbmonster/generator/StringChoiceGenerator.java
| Error | Line |
| Line does not match expected header line of '/* Version 1.0 based on Apache Software License 1.1'. |
1
|
| Missing a Javadoc comment. |
36
|
| Missing a Javadoc comment. |
37
|
| Missing a Javadoc comment. |
38
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Missing a Javadoc comment. |
40
|
| Parameter ctx should be final. |
40
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
58
|
| Missing a Javadoc comment. |
58
|
| '101' is a magic number. |
59
|
| Method 'getChoice' is not designed for extension - needs to be abstract, final or empty. |
65
|
| Missing a Javadoc comment. |
65
|
| Method 'setChoice' is not designed for extension - needs to be abstract, final or empty. |
69
|
| Missing a Javadoc comment. |
69
|
| Parameter argChoice should be final. |
69
|
| Missing a Javadoc comment. |
73
|
pl/kernelpanic/dbmonster/generator/StringGenerator.java
| Error | Line |
| Line is longer than 80 characters. |
92
|
| Line is longer than 80 characters. |
97
|
| '255' is a magic number. |
107
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
141
|
| Parameter ctx should be final. |
141
|
| Line is longer than 80 characters. |
143
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
159
|
| '101' is a magic number. |
161
|
| Method 'setMinLength' is not designed for extension - needs to be abstract, final or empty. |
202
|
| Parameter length should be final. |
202
|
| Method 'getMaxLength' is not designed for extension - needs to be abstract, final or empty. |
211
|
| Method 'setMaxLength' is not designed for extension - needs to be abstract, final or empty. |
220
|
| Parameter length should be final. |
220
|
| Method 'getAllowSpaces' is not designed for extension - needs to be abstract, final or empty. |
230
|
| Method 'setAllowSpaces' is not designed for extension - needs to be abstract, final or empty. |
239
|
| Parameter spaces should be final. |
239
|
| Method 'getExcludeChars' is not designed for extension - needs to be abstract, final or empty. |
248
|
| Method 'setExcludeChars' is not designed for extension - needs to be abstract, final or empty. |
262
|
| Parameter chars should be final. |
262
|
| Parameter str should be final. |
286
|
pl/kernelpanic/dbmonster/generator/StringKeyGenerator.java
| Error | Line |
| '26' is a magic number. |
107
|
| Method 'setKey' is not designed for extension - needs to be abstract, final or empty. |
119
|
| Parameter k should be final. |
119
|
| Method 'getKey' is not designed for extension - needs to be abstract, final or empty. |
123
|
| Missing a Javadoc comment. |
123
|
| Method 'getColumns' is not designed for extension - needs to be abstract, final or empty. |
132
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
143
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
158
|
| Parameter ctx should be final. |
158
|
| Method 'getColumnName' is not designed for extension - needs to be abstract, final or empty. |
216
|
| Method 'setColumnName' is not designed for extension - needs to be abstract, final or empty. |
231
|
| Parameter name should be final. |
231
|
| Parameter s should be final. |
244
|
| Method 'getStartValue' is not designed for extension - needs to be abstract, final or empty. |
269
|
| First sentence should end with a period. |
273
|
| Method 'setStartValue' is not designed for extension - needs to be abstract, final or empty. |
278
|
| Parameter sv should be final. |
278
|
pl/kernelpanic/dbmonster/schema/Column.java
| Error | Line |
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
113
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
122
|
| Parameter s should be final. |
122
|
| Method 'getGenerator' is not designed for extension - needs to be abstract, final or empty. |
131
|
| Method 'setGenerator' is not designed for extension - needs to be abstract, final or empty. |
140
|
| Parameter gen should be final. |
140
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
152
|
| Parameter ctx should be final. |
152
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
163
|
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. |
182
|
| Method 'getDatabaseDefault' is not designed for extension - needs to be abstract, final or empty. |
194
|
| First sentence should end with a period. |
198
|
| Method 'setDatabaseDefault' is not designed for extension - needs to be abstract, final or empty. |
204
|
| Parameter isDatabaseDefault should be final. |
204
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
213
|
| Parameter o should be final. |
213
|
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
222
|
| Method 'setTable' is not designed for extension - needs to be abstract, final or empty. |
231
|
| Parameter t should be final. |
231
|
| Method 'getTable' is not designed for extension - needs to be abstract, final or empty. |
240
|
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
247
|
| Parameter o should be final. |
247
|
| Method 'getTargetType' is not designed for extension - needs to be abstract, final or empty. |
254
|
| Method 'setTargetType' is not designed for extension - needs to be abstract, final or empty. |
260
|
| Parameter targetType should be final. |
260
|
| 'targetType' hides a field. |
260
|
pl/kernelpanic/dbmonster/schema/ColumnPredicate.java
| Error | Line |
| Method 'evaluate' is not designed for extension - needs to be abstract, final or empty. |
69
|
| Parameter object should be final. |
69
|
pl/kernelpanic/dbmonster/schema/Key.java
| Error | Line |
| Method 'getGenerator' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Method 'setGenerator' is not designed for extension - needs to be abstract, final or empty. |
102
|
| Parameter gen should be final. |
102
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
114
|
| Parameter ctx should be final. |
114
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
140
|
| Method 'setTable' is not designed for extension - needs to be abstract, final or empty. |
149
|
| Parameter t should be final. |
149
|
| Method 'getTable' is not designed for extension - needs to be abstract, final or empty. |
158
|
| Method 'getDatabaseDefault' is not designed for extension - needs to be abstract, final or empty. |
169
|
| First sentence should end with a period. |
173
|
| Method 'setDatabaseDefault' is not designed for extension - needs to be abstract, final or empty. |
179
|
| Parameter isDatabaseDefault should be final. |
179
|
pl/kernelpanic/dbmonster/schema/Schema.java
| Error | Line |
| Method 'addTable' is not designed for extension - needs to be abstract, final or empty. |
104
|
| Parameter table should be final. |
104
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
125
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
134
|
| Parameter s should be final. |
134
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
145
|
| Parameter ctx should be final. |
145
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
174
|
| Method 'getHome' is not designed for extension - needs to be abstract, final or empty. |
193
|
| Method 'setHome' is not designed for extension - needs to be abstract, final or empty. |
202
|
| Parameter dir should be final. |
202
|
| Method 'findTable' is not designed for extension - needs to be abstract, final or empty. |
213
|
| Parameter tableName should be final. |
213
|
| Method 'getTables' is not designed for extension - needs to be abstract, final or empty. |
222
|
| Method 'removeTable' is not designed for extension - needs to be abstract, final or empty. |
237
|
| Parameter t should be final. |
237
|
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
245
|
| Parameter o should be final. |
245
|
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. |
253
|
pl/kernelpanic/dbmonster/schema/SchemaException.java
| Error | Line |
| Missing a Javadoc comment. |
59
|
| Parameter message should be final. |
66
|
pl/kernelpanic/dbmonster/schema/SchemaUtil.java
| Error | Line |
| Parameter fileName should be final. |
175
|
| Parameter log should be final. |
175
|
| Line has trailing spaces. |
178
|
| Line is longer than 80 characters. |
179
|
| Missing a Javadoc comment. |
179
|
| Parameter fileName should be final. |
179
|
| Parameter log should be final. |
179
|
| Parameter classloader should be final. |
179
|
| Parameter url should be final. |
201
|
| Parameter log should be final. |
201
|
| Parameter is should be final. |
217
|
| Parameter log should be final. |
217
|
| Line is longer than 80 characters. |
222
|
| Missing a Javadoc comment. |
222
|
| Parameter is should be final. |
222
|
| Parameter log should be final. |
222
|
| Parameter classloader should be final. |
222
|
| Parameter exception should be final. |
227
|
| Parameter exception should be final. |
232
|
| Parameter exception should be final. |
237
|
| Parameter schema should be final. |
297
|
| Parameter table should be final. |
327
|
| Parameter key should be final. |
364
|
| Parameter column should be final. |
384
|
| Parameter object should be final. |
408
|
| '3' is a magic number. |
431
|
| Parameter object should be final. |
455
|
| Parameter name should be final. |
455
|
| Line is longer than 80 characters. |
486
|
| Parameter writer should be final. |
486
|
| Parameter schema should be final. |
486
|
| Line is longer than 80 characters. |
519
|
| Parameter writer should be final. |
519
|
| Parameter table should be final. |
519
|
| Parameter writer should be final. |
546
|
| Parameter key should be final. |
546
|
| Line is longer than 80 characters. |
564
|
| Parameter writer should be final. |
564
|
| Parameter column should be final. |
564
|
| Line is longer than 80 characters. |
584
|
| Parameter writer should be final. |
584
|
| Parameter generator should be final. |
584
|
| Parameter attributes should be final. |
621
|
| Parameter attributes should be final. |
644
|
pl/kernelpanic/dbmonster/schema/Table.java
| Error | Line |
| '1000L' is a magic number. |
121
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
138
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
147
|
| Parameter s should be final. |
147
|
| Method 'getSchema' is not designed for extension - needs to be abstract, final or empty. |
156
|
| Method 'setSchema' is not designed for extension - needs to be abstract, final or empty. |
165
|
| Parameter s should be final. |
165
|
| Missing a Javadoc comment. |
174
|
| Method 'addColumn' is not designed for extension - needs to be abstract, final or empty. |
183
|
| Parameter column should be final. |
183
|
| Line is longer than 80 characters. |
189
|
| Method 'setKey' is not designed for extension - needs to be abstract, final or empty. |
200
|
| Parameter k should be final. |
200
|
| Method 'getKey' is not designed for extension - needs to be abstract, final or empty. |
212
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
224
|
| Parameter ctx should be final. |
224
|
| Line is longer than 80 characters. |
240
|
| Line is longer than 80 characters. |
242
|
| Line is longer than 80 characters. |
253
|
| Line is longer than 80 characters. |
257
|
| Line is longer than 80 characters. |
266
|
| Line is longer than 80 characters. |
280
|
| Line is longer than 80 characters. |
333
|
| Method 'generate' is not designed for extension - needs to be abstract, final or empty. |
342
|
| Line is longer than 80 characters. |
346
|
| Line is longer than 80 characters. |
354
|
| Line is longer than 80 characters. |
397
|
| Line is longer than 80 characters. |
398
|
| Line is longer than 80 characters. |
400
|
| Line is longer than 80 characters. |
402
|
| Line is longer than 80 characters. |
404
|
| Line is longer than 80 characters. |
413
|
| Line is longer than 80 characters. |
414
|
| Line is longer than 80 characters. |
416
|
| Line has trailing spaces. |
417
|
| 'cast' is not followed by whitespace. |
419
|
| Line is longer than 80 characters. |
423
|
| Line is longer than 80 characters. |
425
|
| Line is longer than 80 characters. |
432
|
| Line is longer than 80 characters. |
444
|
| Line is longer than 80 characters. |
449
|
| Line is longer than 80 characters. |
469
|
| Line has trailing spaces. |
473
|
| Method 'resetColumns' is not designed for extension - needs to be abstract, final or empty. |
477
|
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. |
487
|
| Method 'getRows' is not designed for extension - needs to be abstract, final or empty. |
502
|
| Method 'setRows' is not designed for extension - needs to be abstract, final or empty. |
511
|
| Parameter i should be final. |
511
|
| Method 'isGenerated' is not designed for extension - needs to be abstract, final or empty. |
520
|
| Method 'columnIterator' is not designed for extension - needs to be abstract, final or empty. |
529
|
| Method 'getColumns' is not designed for extension - needs to be abstract, final or empty. |
538
|
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
545
|
| Parameter o should be final. |
545
|
| Method 'removeColumn' is not designed for extension - needs to be abstract, final or empty. |
555
|
| Parameter column should be final. |
555
|
| Method 'containsColumn' is not designed for extension - needs to be abstract, final or empty. |
565
|
| Missing a Javadoc comment. |
565
|
| Parameter name should be final. |
565
|
| 'name' hides a field. |
565
|
| Method 'findColumn' is not designed for extension - needs to be abstract, final or empty. |
575
|
| Missing a Javadoc comment. |
575
|
| Parameter name should be final. |
575
|
| 'name' hides a field. |
575
|
| Line has trailing spaces. |
586
|
| Line has trailing spaces. |
589
|
| Method 'getUnqualifiedName' is not designed for extension - needs to be abstract, final or empty. |
592
|
| '+' is not preceded with whitespace. |
595
|
| '+' is not followed by whitespace. |
595
|
| Line has trailing spaces. |
599
|
| Line has trailing spaces. |
601
|
| Line has trailing spaces. |
603
|
| Line has trailing spaces. |
605
|
| Parameter type should be final. |
608
|
| Conditional logic can be removed. |
609
|
| Line has trailing spaces. |
612
|
| '{' should be on the previous line. |
613
|
| Line has trailing spaces. |
618
|
pl/kernelpanic/dbmonster/sql/ExtendedTypes.java
| Error | Line |
| Class ExtendedTypes should be declared as final. |
59
|
| Name 'single' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
64
|
| Line has trailing spaces. |
70
|
| First sentence should end with a period. |
71
|
| Line has trailing spaces. |
76
|
| Line has trailing spaces. |
80
|
| '-9' is a magic number. |
82
|
| Parameter driverName should be final. |
101
|
| Parameter type should be final. |
101
|
| Line has trailing spaces. |
105
|
| 'if' construct must use '{}'s. |
109
|
| Line has trailing spaces. |
119
|
| Parameter driverName should be final. |
123
|
| Parameter nonStandardType should be final. |
124
|
| Line has trailing spaces. |
129
|
| 'if' construct must use '{}'s. |
134
|
| Parameter driverName should be final. |
146
|
pl/kernelpanic/dbmonster/sql/package.html
| Error | Line |
| Missing package documentation file. | 0 |
pl/kernelpanic/dbmonster/util/Converter.java
| Error | Line |
| Parameter ms should be final. |
72
|
| '3600000' is a magic number. |
77
|
| '3600000' is a magic number. |
82
|
| '60000' is a magic number. |
85
|
| '60000' is a magic number. |
92
|
| '1000' is a magic number. |
95
|
| '1000' is a magic number. |
102
|
| First sentence should end with a period. |
120
|
| Parameter nulls should be final. |
127
|
| '100' is a magic number. |
128
|
| '100' is a magic number. |
131
|
| '100' is a magic number. |
132
|
pl/kernelpanic/dbmonster/util/ScriptReaderIterator.java
| Error | Line |
| Line does not match expected header line of '/* Version 1.0 based on Apache Software License 1.1'. |
1
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
37
|
| Parameter script should be final. |
37
|
| Missing a Javadoc comment. |
42
|
| Parameter reader should be final. |
42
|
| 'reader' hides a field. |
42
|
| Missing a Javadoc comment. |
47
|
| Parameter file should be final. |
47
|
| Line is longer than 80 characters. |
48
|
| Missing a Javadoc comment. |
52
|
| Method 'hasNext' is not designed for extension - needs to be abstract, final or empty. |
55
|
| Missing a Javadoc comment. |
55
|
| Method 'next' is not designed for extension - needs to be abstract, final or empty. |
59
|
| Missing a Javadoc comment. |
59
|
| Missing a Javadoc comment. |
65
|